-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v8/deps): Upgrade all OpenTelemetry dependencies #15098
Conversation
The tests here are expected to fail until #15094 lands. |
@AbhiPrasad hello again! Wondering if you can offer any insight into why the I added some logging of sentry-javascript/dev-packages/node-integration-tests/utils/runner.ts Lines 273 to 275 in c307597
It looks like the connection to the mssql server is failing: breadcrumbs: [
{
timestamp: 1737481330.83,
category: 'console',
level: 'error',
message: "ConnectionError: Login failed for user 'sa'.\n" +
' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n' +
' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n' +
' at Readable.emit (node:events:519:28)\n' +
' at addChunk (node:internal/streams/readable:559:12)\n' +
' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n' +
' at Readable.push (node:internal/streams/readable:391:5)\n' +
' at nextAsync (node:internal/streams/from:194:22)\n' +
' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n' +
" code: 'ELOGIN'\n" +
'}'
}
], |
closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning. Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at |
Thanks @nwalters512 you are a champion! 🏆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are now passing, this backport LGTM.
Thanks so much for this @nwalters512!
Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.