fix(v8/react): From location can be undefined in Tanstack Router Instrumentation #15237
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
mydea and
andreiborza
and removed request for
a team
Lms24
force-pushed
the
lms/v8-backport-tanstack-router-fix
branch
from
0a9c4d0 to
09a3f36
Compare
mydea
approved these changes
Jan 31, 2025
|
Maybe we also want to include #15241 here? |
|
Cherry-picked 2e189d5 onto this PR. Thanks for pointing this out! |
alexandresoro
pushed a commit
to alexandresoro/ouca-web
that referenced
this pull request
Feb 2, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.52.1` -> `8.53.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.52.1/8.53.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@​sentry/react)</summary> ### [`v8.53.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.53.0) [Compare Source](getsentry/sentry-javascript@8.52.1...8.53.0) - feat(v8/nuxt): Add `url` to `SourcemapsUploadOptions` ([#​15202](getsentry/sentry-javascript#15202)) - fix(v8/react): `fromLocation` can be undefined in Tanstack Router Instrumentation ([#​15237](getsentry/sentry-javascript#15237)) Work in this release was contributed by [@​tannerlinsley](https://github.com/tannerlinsley). Thank you for your contribution! #### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 23.3 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 23.17 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 35.9 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 73.27 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 66.71 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 77.57 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 89.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.51 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.91 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.71 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.98 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 38.71 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 27.58 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 37.75 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 23.46 KB | | CDN Bundle | 24.49 KB | | CDN Bundle (incl. Tracing) | 37.6 KB | | CDN Bundle (incl. Tracing, Replay) | 72.9 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 78.23 KB | | CDN Bundle - uncompressed | 71.92 KB | | CDN Bundle (incl. Tracing) - uncompressed | 111.52 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 225.78 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 238.88 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 38.96 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 36.4 KB | | [@​sentry/node](https://github.com/sentry/node) | 162.84 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 99.15 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 126.67 KB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDkuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0OS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca-web/pulls/71 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
alexandresoro
pushed a commit
to alexandresoro/ouca-backend
that referenced
this pull request
Feb 2, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.52.1` -> `8.53.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.52.1/8.53.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@​sentry/node)</summary> ### [`v8.53.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.53.0) [Compare Source](getsentry/sentry-javascript@8.52.1...8.53.0) - feat(v8/nuxt): Add `url` to `SourcemapsUploadOptions` ([#​15202](getsentry/sentry-javascript#15202)) - fix(v8/react): `fromLocation` can be undefined in Tanstack Router Instrumentation ([#​15237](getsentry/sentry-javascript#15237)) Work in this release was contributed by [@​tannerlinsley](https://github.com/tannerlinsley). Thank you for your contribution! #### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 23.3 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 23.17 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 35.9 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 73.27 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 66.71 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 77.57 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 89.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.51 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.91 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.71 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.98 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 38.71 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 27.58 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 37.75 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 23.46 KB | | CDN Bundle | 24.49 KB | | CDN Bundle (incl. Tracing) | 37.6 KB | | CDN Bundle (incl. Tracing, Replay) | 72.9 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 78.23 KB | | CDN Bundle - uncompressed | 71.92 KB | | CDN Bundle (incl. Tracing) - uncompressed | 111.52 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 225.78 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 238.88 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 38.96 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 36.4 KB | | [@​sentry/node](https://github.com/sentry/node) | 162.84 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 99.15 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 126.67 KB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDkuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0OS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca-backend/pulls/519 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #15235 and #15241