fix(sveltekit): Avoid top-level vite import
#15371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Lms24
changed the title
vite import
s1gr1d
approved these changes
Feb 11, 2025
lforst
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When our
sentrySvelteKitvite plugin factory function is called, it needs to load the users' Vite config to determine if they enabled source map generation. This was originally implemented in #14886 for v9, because we no longer want to blindly enable source maps generation for everyone. To load the Vite config, we leverage Vite'sloadConfigFromFileAPI. However, for this, we imported the API fromvite.As reported in #15363, this causes a cyclic
requirechain, which hence causes Node to error when building a SvelteKit app with Node >= 22.12.0. I think this is related to "Require ESM" being introduced in this very node version.The workaround this PR proposes is to avoid the top-level
viteimport/require statement by using a dynamic import ofviteinstead.