[v5] Major utils rewrite #1902
Merged
[v5] Major utils rewrite #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
approved these changes
Feb 19, 2019
| @@ -82,7 +82,7 @@ export class Vue implements Integration { | |||
| } | |||
| } | |||
|
|
|||
| if (!isUndefined(info)) { | |||
| if (info !== void 0) { | |||
| @@ -67,7 +65,7 @@ export class Dsn implements DsnComponents { | |||
| path = split.slice(0, -1).join('/'); | |||
| projectId = split.pop() as string; | |||
| } | |||
| assign(this, { host, pass, path, projectId, port, protocol, user }); | |||
| Object.assign(this, { host, pass, path, projectId, port, protocol, user }); | |||
There was a problem hiding this comment.
jtfr, I know we talked offline but for documentation this will break IE 10 for sure.
kamilogorek
added a commit
that referenced
this pull request
Feb 19, 2019
* ref: Move ExtendedError to a types package * ref: Remove assign util in favor of Object.assign * ref: Pass Event to sendEvent instead of just a body * ref: Remove isArray and isNaN utils * ref: Rewrite normalization and removed unused utils * Utils rewamp changelog
HazAT
pushed a commit
that referenced
this pull request
Feb 20, 2019
* ref: Move ExtendedError to a types package * ref: Remove assign util in favor of Object.assign * ref: Pass Event to sendEvent instead of just a body * ref: Remove isArray and isNaN utils * ref: Rewrite normalization and removed unused utils * Utils rewamp changelog
HazAT
pushed a commit
that referenced
this pull request
Feb 21, 2019
* ref: Move ExtendedError to a types package * ref: Remove assign util in favor of Object.assign * ref: Pass Event to sendEvent instead of just a body * ref: Remove isArray and isNaN utils * ref: Rewrite normalization and removed unused utils * Utils rewamp changelog
kamilogorek
added a commit
that referenced
this pull request
Feb 26, 2019
* ref: Move ExtendedError to a types package * ref: Remove assign util in favor of Object.assign * ref: Pass Event to sendEvent instead of just a body * ref: Remove isArray and isNaN utils * ref: Rewrite normalization and removed unused utils
HazAT
pushed a commit
that referenced
this pull request
Mar 19, 2019
* ref: Move ExtendedError to a types package * ref: Remove assign util in favor of Object.assign * ref: Pass Event to sendEvent instead of just a body * ref: Remove isArray and isNaN utils * ref: Rewrite normalization and removed unused utils
HazAT
pushed a commit
that referenced
this pull request
Mar 20, 2019
* ref: Move ExtendedError to a types package * ref: Remove assign util in favor of Object.assign * ref: Pass Event to sendEvent instead of just a body * ref: Remove isArray and isNaN utils * ref: Rewrite normalization and removed unused utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.