fix(tracing): Don't consider tracingOrigins when creating spans
#6039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
I guess this would be a breaking change then right? But it's more correct behavior, so I'd be fine with keeping it. |
|
Yep, my comment further down the linked issue mentions just that. Feels breaking but fixes incorrect behaviour so technically isn't 🤔 This change would certainly need to be prominent in the change-log! |
|
P.S. I left some comments in #6041 about tests which by rights probably should be in this PR. I'll leave it up to you where to put them, but we should definitely test the new behavior somewhere. |
AbhiPrasad
approved these changes
Oct 27, 2022
3 tasks
Lms24
pushed a commit
that referenced
this pull request
Oct 28, 2022
In the process of working on #5285, we missed the fact that the first two PRs (#6039 and #6041) were interdependent, in that the former accidentally introduced a bug (#6077) which the latter then inadvertently fixed. This would have been fine, except that we published a release after merging the bug-creating PR but before merging the bug-fixing PR. Whoops. This patch pulls just the bug-fixing part out of the second PR. It also adds tests to cover the buggy cases, using `it.each` to cover all of the different combinations of outcomes for `shouldCreateSpanForRequest` and `shouldAttachHeaders`. Finally, since I was already in the test file, I reorganized it a little: - `it('does not create span if shouldCreateSpan returns false')` -> absorbed into the `it.each()` - `it('does not create span if there is no fetch data in handler data')` -> added header check, became `it('adds neither fetch request spans nor fetch request headers if there is no fetch data in handler data')` - `it('does not add fetch request spans if tracing is disabled')` and `it('does not add fetch request headers if tracing is disabled` -> combined into `it('adds neither fetch request spans nor fetch request headers if tracing is disabled')` - `it('adds sentry-trace header to fetch requests')` -> absorbed into the `it.each()` - Similar changes made to XHR tests Co-authored-by: Tim Fish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ap per Katie's summary here, tracing origins should not be considered when creating spans.
Current span creation
tracingOriginsmatchtracingOriginsmatchshouldCreateSpanForRequestreturnstrueshouldCreateSpanForRequestreturnsfalseshouldCreateSpanForRequestis undefinedtracingOriginsdoes not matter.After this PR
shouldCreateSpanForRequestreturnstrueshouldCreateSpanForRequestreturnsfalseshouldCreateSpanForRequestis undefined