Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add universal buildMetadata function #7404

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export { getIntegrationsToSetup } from './integration';
export { FunctionToString, InboundFilters } from './integrations';
export { prepareEvent } from './utils/prepareEvent';
export { hasTracingEnabled } from './utils/hasTracingEnabled';
export { buildMetadata } from './utils/buildMetadata';
export { DEFAULT_ENVIRONMENT } from './constants';

import * as Integrations from './integrations';
Expand Down
26 changes: 26 additions & 0 deletions packages/core/src/utils/buildMetadata.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import type { Options, SdkInfo } from '@sentry/types';

import { SDK_VERSION } from '../version';

const PACKAGE_NAME_PREFIX = 'npm:@sentry/';

/**
* A builder for the SDK metadata in the options for the SDK initialization.
*
* @param options sdk options object that gets mutated
* @param sdkName name of the SDK (e.g. 'nextjs')
* @param packageNames list of package names (e.g. ['nextjs', 'react'])
*/
export function buildMetadata(options: Options, sdkName: string, packageNames: string[]): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: I would suggest either making this function pure (ie. making it return a new obj) or call it something like applyMetadata() because it mutates the passed options object.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we move forward with this (see other comments), I think I'm gonna go with applyMetadata for bundle size reasons

options._metadata = options._metadata || {};
options._metadata.sdk =
options._metadata.sdk ||
({
name: `sentry.javascript.${sdkName}`,
packages: packageNames.map(name => ({
name: `${PACKAGE_NAME_PREFIX}${name}`,
version: SDK_VERSION,
})),
version: SDK_VERSION,
} as SdkInfo);
}
45 changes: 45 additions & 0 deletions packages/core/test/lib/utils/buildMetadata.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import { buildMetadata } from '../../../src/utils/buildMetadata';
import { SDK_VERSION } from '../../../src/version';

describe('buildMetadata', () => {
it('adds SDK name and packages to the passed options object', () => {
const options = {};
const sdkName = 'jQuery';

buildMetadata(options, sdkName, ['jQuery', 'browser']);

expect(options).toEqual({
_metadata: {
sdk: {
name: `sentry.javascript.${sdkName}`,
packages: [
{
name: 'npm:@sentry/jQuery',
version: SDK_VERSION,
},
{
name: 'npm:@sentry/browser',
version: SDK_VERSION,
},
],
version: SDK_VERSION,
},
},
});
});

it('does not overwrite existing SDK metadata', () => {
const options = {
_metadata: {
sdk: {
name: 'sentry.javascript.SomeSDK',
version: '7.40.0',
},
},
};

buildMetadata(options, 'jQuery', ['jQuery', 'browser']);

expect(options).toStrictEqual(options);
});
});