-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add universal buildMetadata
function
#7404
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import type { Options, SdkInfo } from '@sentry/types'; | ||
|
||
import { SDK_VERSION } from '../version'; | ||
|
||
const PACKAGE_NAME_PREFIX = 'npm:@sentry/'; | ||
|
||
/** | ||
* A builder for the SDK metadata in the options for the SDK initialization. | ||
* | ||
* @param options sdk options object that gets mutated | ||
* @param sdkName name of the SDK (e.g. 'nextjs') | ||
* @param packageNames list of package names (e.g. ['nextjs', 'react']) | ||
*/ | ||
export function buildMetadata(options: Options, sdkName: string, packageNames: string[]): void { | ||
options._metadata = options._metadata || {}; | ||
options._metadata.sdk = | ||
options._metadata.sdk || | ||
({ | ||
name: `sentry.javascript.${sdkName}`, | ||
packages: packageNames.map(name => ({ | ||
name: `${PACKAGE_NAME_PREFIX}${name}`, | ||
version: SDK_VERSION, | ||
})), | ||
version: SDK_VERSION, | ||
} as SdkInfo); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { buildMetadata } from '../../../src/utils/buildMetadata'; | ||
import { SDK_VERSION } from '../../../src/version'; | ||
|
||
describe('buildMetadata', () => { | ||
it('adds SDK name and packages to the passed options object', () => { | ||
const options = {}; | ||
const sdkName = 'jQuery'; | ||
|
||
buildMetadata(options, sdkName, ['jQuery', 'browser']); | ||
|
||
expect(options).toEqual({ | ||
_metadata: { | ||
sdk: { | ||
name: `sentry.javascript.${sdkName}`, | ||
packages: [ | ||
{ | ||
name: 'npm:@sentry/jQuery', | ||
version: SDK_VERSION, | ||
}, | ||
{ | ||
name: 'npm:@sentry/browser', | ||
version: SDK_VERSION, | ||
}, | ||
], | ||
version: SDK_VERSION, | ||
}, | ||
}, | ||
}); | ||
}); | ||
|
||
it('does not overwrite existing SDK metadata', () => { | ||
const options = { | ||
_metadata: { | ||
sdk: { | ||
name: 'sentry.javascript.SomeSDK', | ||
version: '7.40.0', | ||
}, | ||
}, | ||
}; | ||
|
||
buildMetadata(options, 'jQuery', ['jQuery', 'browser']); | ||
|
||
expect(options).toStrictEqual(options); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: I would suggest either making this function pure (ie. making it return a new obj) or call it something like
applyMetadata()
because it mutates the passed options object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we move forward with this (see other comments), I think I'm gonna go with
applyMetadata
for bundle size reasons