fix(node): Revert to dynamic require
for http(s)
monkey patching
#7430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #7377 which caused monkey patching errors when patching the native
http
andhttps
modules in the Node SDK (#7425). Similarly, also our Serverless SDK was subjected to the same problem (#7421).The problem is that
import
doesn't permit monkey patching of the importedhttp
module functions, producing this error:I tried using a dynamic import instead but got the same result. So it seems like we can only use
require
here :(This also seems to be a known problem for the oTel folks: open-telemetry/opentelemetry-js#1946
Merging this PR means, we'll have to think of something for the SvelteKit SDK but we should nevertheless do it and cut a release to unblock everyone experiencing this error.
closes #7425
closes #7421