Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sveltekit): Add meta tag for backend -> frontend #7574

Merged
merged 1 commit into from
Mar 24, 2023
Merged

feat(sveltekit): Add meta tag for backend -> frontend #7574

merged 1 commit into from
Mar 24, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 22, 2023 •
edited
Loading

ref #7526

Using the SvelteKit handle function, insert in a meta tag to add backend -> frontend tracing.

@AbhiPrasad AbhiPrasad requested a review from Lms24 March 22, 2023 16:43
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 22, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (+0.65% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.19 KB (+1.06% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.9 KB (+0.47% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.3 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.36 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.49 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.03 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad force-pushed the abhi-transform-page-chunk branch from fba75fd to 50d6193 Compare March 22, 2023 19:31
@AbhiPrasad AbhiPrasad self-assigned this Mar 23, 2023
Lms24
Lms24 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AbhiPrasad AbhiPrasad merged commit 11704a3 into develop Mar 24, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-transform-page-chunk branch March 24, 2023 12:03
@Lms24 Lms24 mentioned this pull request Mar 24, 2023
Merged
Lms24 added a commit that referenced this pull request Mar 27, 2023
@Lms24
fix(sveltekit): Fix <meta> tag injection (#7612)
f6ce5c9 
Apparently, the `%sveltekit.head%` placeholder isn't present in the html that's passed to `transformPageChunk`. Hence our `<meta>` tag injection logic introduced in #7574  didn't find the anchor point where to inject the tags. This PR fixes the injection, by simply appending it to an open `<head>` tag. It's not pretty but it should do the trick 🤞 (we can revisit if this breaks folks).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @Lms24