Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(angular): Fix Nx dependency graph for Angular #8841

Merged
merged 1 commit into from
Aug 18, 2023
Merged

build(angular): Fix Nx dependency graph for Angular #8841

merged 1 commit into from
Aug 18, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 18, 2023

Angular build:transpile actually depends on types, so we need to reflect that - otherwise, yarn build:dev fails if no types are built yet.

Steps to reproduce:

yarn clean
yarn build:dev

Used to fail before this.

Supersedes #8840

@mydea
build(angular): Fix Nx dependency graph for Angular
0a1ce3e 
Angular `build:transpile` actually depends on types, so we need to reflect that - otherwise, `yarn build:dev` fails if no types are built yet.

Steps to reproduce:

```sh
yarn clean
yarn build:dev
```

Used to fail before this.
@mydea mydea requested review from lforst and Lms24 August 18, 2023 11:26
@mydea mydea self-assigned this Aug 18, 2023
@mydea mydea mentioned this pull request Aug 18, 2023
Closed
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.19 KB (+0.46% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.17 KB (+0.2% 🔺)
@sentry/browser - Webpack (gzipped) 21.85 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.73 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.18 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.95 KB (+0.41% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.78 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.86 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.04 KB (+0.09% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.21 KB (+15.62% 🔺)
@sentry/react - Webpack (gzipped) 21.88 KB (+0.18% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.03 KB (+0.41% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.7 KB (+0.19% 🔺)

Lms24
Lms24 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, Angular needs types. Good point! We used to just explicitly build it at (iirc yarn build:extras) the end but this makes more sense.

@mydea mydea merged commit 2d80b4b into develop Aug 18, 2023
@mydea mydea deleted the fn/fix-angular-nx-dependency-graph branch August 18, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24