Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Laravel PR gifted us insight in the preparing of a response: laravel/framework#47229.
We can use that to add a
http.route.response
span which will identify possible actions taken to prepare the response, especially when usingIlluminate\Contracts\Support\Responsable
classes.Before:
After:
In the example it's just a fake
sleep
span, but any number of things can happen to prepare the response like running queries and/or making HTTP calls which would be very nice to have grouped underhttp.route.response
instead of directly undermiddleware.handle
.This will also cause view rendering to be grouped under this new span since views also are only rendered after being returned from the route handler (controller/closure etc.):
Happy to take suggestions on better naming!