Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape spaces in paths #64

Merged
merged 10 commits into from
May 3, 2024
Merged

Escape spaces in paths #64

merged 10 commits into from
May 3, 2024

Conversation

adinauer
Copy link
Member

📜 Description

Escape spaces in paths sent to sentry-cli.

💡 Motivation and Context

Fixes #62

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

  • needs testing on an actual windows machine

@adinauer adinauer requested a review from lbloder March 14, 2024 13:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 55cacd5

lbloder
lbloder requested changes Mar 22, 2024
View reviewed changes
src/main/java/io/sentry/cli/SentryCliRunner.java Outdated Show resolved Hide resolved
src/main/java/io/sentry/cli/SentryCliRunner.java Outdated Show resolved Hide resolved
markushi
markushi approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor nit.

src/main/java/io/sentry/cli/SentryCliRunner.java Outdated Show resolved Hide resolved
@adinauer adinauer merged commit 0530283 into main May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbloder lbloder lbloder approved these changes

@markushi markushi markushi approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to upload source bundle with sentry-cli on Windows if project.build.directory contains whitespace
3 participants
@adinauer @markushi @lbloder