Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Support for Maven Plugin #7

Merged
merged 8 commits into from
Jun 29, 2023
Merged

Windows Support for Maven Plugin #7

merged 8 commits into from
Jun 29, 2023

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Jun 29, 2023 •
edited
Loading

📜 Description

  • Check if OS is Windows and adapt command for launching SentryCli accordingly
  • Honor url and authToken parameters in upload command

💡 Motivation and Context

Fixes #5

💚 How did you test it?

  • Built and ran on Windows and MacOS.
  • Checked Issues on Sentry UI.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@lbloder lbloder marked this pull request as ready for review June 29, 2023 10:15
adinauer
adinauer approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

@adinauer adinauer merged commit 14abc19 into getsentry:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lbloder @adinauer