fix: Fix false positives for comment lookup

src/transformers/addMigrationComments/addMigrationComments.test.js

@@ -60,6 +60,32 @@ function doSomethingElse() {
     );
   });
 
+  it('works with TS', async () => {
+    tmpDir = makeTmpDir(getFixturePath('addMigrationComments'));
+    const file = 'noFalsePositives.ts';
+    const files = [`${tmpDir}/${file}`];
+    await tracingConfigTransformer.transform(files, { filePatterns: [] });
+
+    const actual = getDirFileContent(tmpDir, file);
+
+    assertStringEquals(
+      actual,
+      `function indexMembersByProject(members: Member[]): IndexedMembersByProject {
+  return members.reduce<IndexedMembersByProject>((acc, member) => {
+    for (const project of member.projects) {
+      if (!acc.hasOwnProperty(project)) {
+        acc[project] = [];
+      }
+      if (member.user) {
+        acc[project].push(member.user);
+      }
+    }
+    return acc;
+  }, {});
+}`
+    );
+  });
+
   it('works with span.startChild', async () => {
     tmpDir = makeTmpDir(getFixturePath('addMigrationComments'));
     const file = 'startChild.js';

src/transformers/addMigrationComments/transform.cjs

@@ -14,15 +14,20 @@ module.exports = function (fileInfo, api) {
   return wrapJscodeshift(j, source, fileName, (j, source) => {
     const tree = j(source);
 
-    /** @type {Record<string,string>} */
-    const methodCommentMap = {
-      startTransaction:
+    const methodCommentMap = new Map([
+      [
+        'startTransaction',
         'Use `startInactiveSpan()` instead - see https://github.com/getsentry/sentry-javascript/blob/develop/docs/v8-new-performance-apis.md',
-      startChild:
+      ],
+      [
+        'startChild',
         'Use `startInactiveSpan()` instead - see https://github.com/getsentry/sentry-javascript/blob/develop/docs/v8-new-performance-apis.md',
-      makeMain:
+      ],
+      [
+        'makeMain',
         'Use `setCurrentClient()` instead - see https://github.com/getsentry/sentry-javascript/blob/develop/docs/v8-initializing.md',
-    };
+      ],
+    ]);
 
     // Find `xxx()` calls
     tree
@@ -33,7 +38,7 @@ module.exports = function (fileInfo, api) {
       })
       .forEach(path => {
         if (path.value.callee.type === 'Identifier') {
-          const comment = methodCommentMap[path.value.callee.name];
+          const comment = methodCommentMap.get(path.value.callee.name);
           if (comment) {
             addTodoComment(j, path, comment);
           }
@@ -52,7 +57,7 @@ module.exports = function (fileInfo, api) {
       })
       .forEach(path => {
         if (path.value.callee.type === 'MemberExpression' && path.value.callee.property.type === 'Identifier') {
-          const comment = methodCommentMap[path.value.callee.property.name];
+          const comment = methodCommentMap.get(path.value.callee.property.name);
           if (comment) {
             addTodoComment(j, path, comment);
           }

test-fixtures/addMigrationComments/noFalsePositives.ts

@@ -0,0 +1,13 @@
+function indexMembersByProject(members: Member[]): IndexedMembersByProject {
+  return members.reduce<IndexedMembersByProject>((acc, member) => {
+    for (const project of member.projects) {
+      if (!acc.hasOwnProperty(project)) {
+        acc[project] = [];
+      }
+      if (member.user) {
+        acc[project].push(member.user);
+      }
+    }
+    return acc;
+  }, {});
+}