This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
feat: Update Node SDK to latest v7 and use metrics #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
May 15, 2024
| */ | ||
| function createSentryInstance(enabled) { | ||
| const client = new NodeClient({ | ||
| Sentry.init({ |
There was a problem hiding this comment.
what we had before worked but I think for migr8 it's fine to actually simply call Sentry.init. We don't have the same leaking concerns as in the plugins. Additionally, we still don't add global integrations
Lms24
requested review from
a team,
mydea and
lforst
and removed request for
a team
mydea
approved these changes
May 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK to latest v7. For the v8 bump, I'll transpile to CJS first. Gonna do more important things first though 😅
Also adds a couple of metrics to maybe eventually move from transaction/tags usage telemetry to metrics usage telemetry 👀