-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: Add transaction tag methods #626
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c3ef980
tracing: Add transaction tag methods
loewenheim 53783ce
Add remove_data method
loewenheim 88fa666
Add docs
loewenheim 6521807
Change remove method signatures
loewenheim 87d627d
Fix docs
loewenheim b6c6f22
Fix formatting
loewenheim 1a167e4
Merge branch 'master' into tracing/transaction-tags
loewenheim 9bd0985
Separate functions for spans and transactions
loewenheim 3881e05
Limit tags to 200 bytes
loewenheim d818544
Formatting
loewenheim fb5cf03
Typo
loewenheim 7ee71a9
Bugfix
loewenheim 5786c5f
formatting
loewenheim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just came across this as well as I added these to the Rust SDK (as part of getsentry/sentry-rust#400)
Do transactions have
data
? Or do they rather haveextra
as inherited from theEvent
?https://develop.sentry.dev/sdk/event-payloads/transaction/ does not mention either as a matter of fact.
I’m confused and don’t know what to believe anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From discussions with @relaxolotl: Every transaction is a span and spans have
data
, so transactions must as well. We're also pretty sure thatdata
andextras
are the same thing.