Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the FrameContextifierIntegration integration #1011

Merged
merged 3 commits into from
May 19, 2020
Merged

Add the FrameContextifierIntegration integration #1011

merged 3 commits into from
May 19, 2020

Conversation

ste93cry
Copy link
Collaborator

@ste93cry ste93cry commented May 5, 2020

Q A
Branch? 2.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
License MIT

Porting of the contextifyFramesIntegration integration of the Go SDK. The main benefit of this change is that we're moving away from the Stacktrace class a lot of code that doesn't belongs there, advancing one more step towards making it a value object and DTO rather than a service that depends on the serializer, the client options, etc.

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is dropping the option: that is a really easy way to set that behavior, removing that would mean forcing the user to fill in a lot of blanks just to set an int...

Apart from that, I do have only some minor fixes to request.

src/Client.php Outdated Show resolved Hide resolved
src/EventFactory.php Outdated Show resolved Hide resolved
src/Integration/FrameContextifierIntegration.php Outdated Show resolved Hide resolved
src/Integration/FrameContextifierIntegration.php Outdated Show resolved Hide resolved
src/Options.php Outdated Show resolved Hide resolved
@ste93cry ste93cry requested a review from Jean85 May 15, 2020 20:59
CHANGELOG.md Outdated Show resolved Hide resolved
phpstan.neon Show resolved Hide resolved
phpstan.neon Show resolved Hide resolved
src/Options.php Outdated Show resolved Hide resolved
src/Stacktrace.php Show resolved Hide resolved
@ste93cry ste93cry merged commit 2483b41 into getsentry:develop May 19, 2020
@ste93cry ste93cry deleted the feature/add-frame-contextifier-integration branch May 19, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants