-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the FrameContextifierIntegration integration #1011
Merged
ste93cry
merged 3 commits into
getsentry:develop
from
ste93cry:feature/add-frame-contextifier-integration
May 19, 2020
Merged
Add the FrameContextifierIntegration integration #1011
ste93cry
merged 3 commits into
getsentry:develop
from
ste93cry:feature/add-frame-contextifier-integration
May 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is dropping the option: that is a really easy way to set that behavior, removing that would mean forcing the user to fill in a lot of blanks just to set an int...
Apart from that, I do have only some minor fixes to request.
Jean85
requested changes
May 18, 2020
Jean85
approved these changes
May 19, 2020
stayallive
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting of the contextifyFramesIntegration integration of the Go SDK. The main benefit of this change is that we're moving away from the
Stacktrace
class a lot of code that doesn't belongs there, advancing one more step towards making it a value object and DTO rather than a service that depends on the serializer, the client options, etc.