Fix README.md top logo #469
Conversation
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| <p align="center"> | |||
| <a href="https://sentry.io" target="_blank" align="center"> | |||
| <img src="https://a0wx592cvgzripj.global.ssl.fastly.net/_static/f9c485ccdb254095d3cac55524daba0a/getsentry/images/branding/svg/sentry-horizontal-black.svg" width="280"> | |||
| <img src="https://a0wx592cvgzripj.global.ssl.fastly.net/_static/a9bbea2ddc9304e1c4b8d9144cb26546/getsentry/images/branding/png/sentry-horizontal-black.png" width="280"> | |||
There was a problem hiding this comment.
We need persistent CDN link. It makes no sense to change one temporary url to another
There was a problem hiding this comment.
I know. I just raised this PR as a temp fix, to raise the issue and to ask for that link.
There was a problem hiding this comment.
@dcramer could just upload logo to https://sentry.io/ so there will be no need to use temporary links from https://sentry.io/branding/
|
@ckj @cameronmcefee do we have permalinks for the logos (vs versioned links)? |
|
No, not currently, but I can make that happen. |
|
@mattrobenolt do you know? |
|
Yup. For example |
|
I'll note these aren't permalinks. They may change if we shuffle things around within the app. But these are at least not versioned. It might be worth moving this into S3 or Google Storage to have explicit permalinks for branding thing? Something not tied to the application. @cameronmcefee |
|
Fine with me |
|
Thanks @mattrobenolt, I've changed the PR to use your static link for now. |
|
You can do a "Squash and merge" @nokitakaze |
|
I can't do merge to |
This is really a small fix, but I think in this way it's only temporary, since it uses a direct URL to a CDN. Do we have a fixed link that we could use altogether?