Update README.md #476
Merged
Update README.md #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Nette framework implementation
Jean85
requested changes
Jun 21, 2017
README.md
Outdated
| @@ -49,6 +49,7 @@ Other packages exists to integrate this SDK into the most common frameworks. | |||
|
|
|||
| - [Symfony](https://github.com/getsentry/sentry-symfony) | |||
| - [Laravel](https://github.com/getsentry/sentry-laravel) | |||
| - [Nette](https://github.com/Salamek/raven-nette) | |||
There was a problem hiding this comment.
I would create a subsection for non-official integrations, so we could add also others like the Wordpress one or https://github.com/facile-it/sentry-module
|
Good Idea, do you will change it?
Dne 21. 6. 2017 13:18 napsal uživatel "Alessandro Lai" <
[email protected]>:
… ***@***.**** requested changes on this pull request.
Thanks for your contribution! I would like you to make a single change
before merging..
------------------------------
In README.md
<#476 (comment)>:
> @@ -49,6 +49,7 @@ Other packages exists to integrate this SDK into the most common frameworks.
- [Symfony](https://github.com/getsentry/sentry-symfony)
- [Laravel](https://github.com/getsentry/sentry-laravel)
+- [Nette](https://github.com/Salamek/raven-nette)
I would create a subsection for non-official integrations, so we could add
also others like the Wordpress one or https://github.com/facile-it/
sentry-module
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#476 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADCWZGWRHgCQtd_jFVxN2ziFPAdabzJzks5sGPwJgaJpZM4OApX_>
.
|
Jean85
approved these changes
Jun 21, 2017
stayallive
approved these changes
Jun 22, 2017
There was a problem hiding this comment.
To merge this I would change the words slightly to be in line with the plugins section in the Sentry documentation.
|
Ok for me! Did you forget to merge? 😄 |
|
I just noticed I can't 😅 working on that 😜 |
|
I did it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added Nette framework implementation