do not auto-attach a backtrace when logging an exception #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
requested changes
Jan 17, 2020
|
haha - creating conflicts with myself - and on CHANGELOG.md no less. rebasing 😊 |
ste93cry
requested changes
Jan 17, 2020
this fixes getsentry#957. The sentry server prefers the event's stacktrace over an attached exception's stacktrace, so if a stacktrace is attached to an event containing an exception, the web interface would show the backtrace to where the exception was captured rather than the exception's backtrace.
this is a change requested in code review in order to remove duplicated logic in `captureMessage` in the future.
captureEvent now does everything this needs
ste93cry
approved these changes
Jan 17, 2020
Jean85
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #957.
The sentry server prefers the event's stacktrace over an attached exception's stacktrace, so if a stacktrace is attached to an event containing an exception, the web interface would show the backtrace to where the exception was captured rather than the exception's backtrace.