Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel Szoke <[email protected]>
  • Loading branch information
sentrivana and szokeasaurusrex authored Feb 3, 2025
1 parent 286e76f commit 0ccb443
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions scripts/populate_tox/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Python versions, you can say:
...
}
```

This key is optional.
### `python`

Sometimes, the whole test suite should only run on specific Python versions.
Expand All @@ -110,8 +110,9 @@ For example, if you want AIOHTTP tests to only run on Python 3.7+, you can say:
}
```

Specifying `python` is discouraged as the script itself finds out which
Python versions are supported by the package. However, if a package has broken
The `python` key is optional, and when possible, it should be omitted. The script
should automatically detect which Python versions the package supports.
However, if a package has broken
metadata or the SDK is explicitly not supporting some packages on specific
Python versions (because of, for example, broken context vars), the `python`
key can be used.
Expand Down
2 changes: 1 addition & 1 deletion scripts/populate_tox/populate_tox.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def write_tox_file(packages: dict) -> None:
file.write("\n")


def _get_package_name(integration: str) -> Tuple[str, Optional[str]]:
def _get_package_name(integration: str) -> tuple[str, Optional[str]]:
package = TEST_SUITE_CONFIG[integration]["package"]
extra = None
if "[" in package:
Expand Down

0 comments on commit 0ccb443

Please sign in to comment.