Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing ASGI to use drf_request in DjangoRequestExtractor #3572

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

PakawiNz
Copy link
Contributor

since we already have patched a request object (both ASGI/WSGI) before arriving, we should move patched-using logic closer to where it actually being used. for minimize impact and allow ASGI functionality.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

since we already have patched a request object (both ASGI/WSGI) before arriving, we should move patched-using logic closer to where it actually being used. for minimize impact and allow ASGI functionality.
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PakawiNz! Makes sense to me.

@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Oct 1, 2024
@github-actions github-actions bot removed the Trigger: tests using secrets PR code is safe; run CI label Oct 1, 2024
@sentrivana sentrivana enabled auto-merge (squash) October 1, 2024 09:27
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.30%. Comparing base (4636afc) to head (fdc0500).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
sentry_sdk/integrations/django/__init__.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3572      +/-   ##
==========================================
- Coverage   84.32%   84.30%   -0.02%     
==========================================
  Files         133      133              
  Lines       13906    13908       +2     
  Branches     2933     2933              
==========================================
- Hits        11726    11725       -1     
- Misses       1441     1449       +8     
+ Partials      739      734       -5     
Files with missing lines Coverage Δ
sentry_sdk/integrations/django/__init__.py 84.16% <87.50%> (+0.08%) ⬆️

... and 6 files with indirect coverage changes

@sentrivana sentrivana merged commit 05411ff into getsentry:master Oct 1, 2024
134 of 136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants