Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of sample_rate in DSC (and add explanatory tests) #3603

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

antonpirker
Copy link
Member

In the DSC send in the envelope header for envelopes containing errors the type of sample_rate was float instead of the correct str type.

Fixes #3601

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (5080c76) to head (d43c9c2).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3603   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         133      133           
  Lines       13929    13929           
  Branches     2938     2938           
=======================================
+ Hits        11748    11749    +1     
+ Misses       1443     1442    -1     
  Partials      738      738           
Files with missing lines Coverage Δ
sentry_sdk/tracing_utils.py 86.08% <100.00%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥔 🥔 🥔

@antonpirker antonpirker merged commit c36f0db into master Oct 3, 2024
136 checks passed
@antonpirker antonpirker deleted the antonpirker/check-dsc-typing branch October 3, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace sample rate in DSC not a string
2 participants