Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2] Add more min versions of frameworks #3973

Open
wants to merge 2 commits into
base: ivana/tox-script-1
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 20, 2025

These mostly come from our existing tox.ini. They're used by the populate_tox.py script to filter out unsupported releases.

They are not actually checked in the integrations. Since they were more of a suggestion before than a hard requirement, we don't want an integration to suddenly stop working for someone who is on an older version. We can consider actually checking them in a new major.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (8572489) to head (b907e69).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           ivana/tox-script-1    #3973   +/-   ##
===================================================
  Coverage               80.20%   80.20%           
===================================================
  Files                     139      139           
  Lines                   15394    15394           
  Branches                 2596     2596           
===================================================
  Hits                    12347    12347           
+ Misses                   2202     2201    -1     
- Partials                  845      846    +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 77.01% <ø> (ø)

... and 3 files with indirect coverage changes

@sentrivana sentrivana changed the title [3] Add more min versions of frameworks [2] Add more min versions of frameworks Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants