Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breadcrumbs): add _meta-tags for truncation of breadcrumbs #4007

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented Jan 30, 2025

  • Implements annotations per https://github.com/getsentry/projects/issues/593
  • Adds an int field to Scope to track the number of truncated breadcrumbs
  • Adds an AnnotatedDeque type to annotate the Deque[Breadcrumbs] intuitively
  • If breadcrumbs were truncated, serialize the AnnotatedDeque to _meta

@shellmayr shellmayr changed the title feat: add breadcrumb annotationvalue feat(breadcrumbs): add _metatags for truncation of breadcrumbs Jan 30, 2025
@shellmayr shellmayr changed the title feat(breadcrumbs): add _metatags for truncation of breadcrumbs feat(breadcrumbs): add _meta-tags for truncation of breadcrumbs Jan 30, 2025
Copy link

codecov bot commented Jan 31, 2025

❌ 14 Tests Failed:

Tests completed Failed Passed Skipped
22041 14 22027 5709
View the top 3 failed tests by shortest run time
tests.test_scrubber test_breadcrumb_extra_scrubbing
Stack Traces | 0.067s run time
tests/test_scrubber.py:139: in test_breadcrumb_extra_scrubbing
    assert event["_meta"]["breadcrumbs"] == {
E   AssertionError: assert {'values': {'0': {'data': {'password': {'': {'rem': [['!config', 's']]}}}}}} == {'values': {'': {'len': [1]},\n            '0': {'data': {'password': {'': {'rem': [['!config', 's']]}}}}}}
E     Differing items:
E     {'values': {'0': {'data': {'password': {'': {'rem': [...]}}}}}} != {'values': {'': {'len': [1]}, '0': {'data': {'password': {'': {'rem': [...]}}}}}}
E     Full diff:
E       {
E     -  'values': {'': {'len': [1]},
E     -             '0': {'data': {'password': {'': {'rem': [['!config',
E     ?  ^^^^^^^^^^^
E     +  'values': {'0': {'data': {'password': {'': {'rem': [['!config',
E     ?  ^^^^^^^^^^^
E                                                             's']]}}}}},
E       }
tests.test_scrubber test_breadcrumb_extra_scrubbing
Stack Traces | 0.07s run time
tests/test_scrubber.py:139: in test_breadcrumb_extra_scrubbing
    assert event["_meta"]["breadcrumbs"] == {
E   AssertionError: assert {'values': {'0': {'data': {'password': {'': {'rem': [['!config', 's']]}}}}}} == {'values': {'': {'len': [1]},\n            '0': {'data': {'password': {'': {'rem': [['!config', 's']]}}}}}}
E     Differing items:
E     {'values': {'0': {'data': {'password': {'': {'rem': [...]}}}}}} != {'values': {'': {'len': [1]}, '0': {'data': {'password': {'': {'rem': [...]}}}}}}
E     Full diff:
E       {
E     -  'values': {'': {'len': [1]},
E     -             '0': {'data': {'password': {'': {'rem': [['!config',
E     ?  ^^^^^^^^^^^
E     +  'values': {'0': {'data': {'password': {'': {'rem': [['!config',
E     ?  ^^^^^^^^^^^
E                                                             's']]}}}}},
E       }
tests.test_scrubber test_breadcrumb_extra_scrubbing
Stack Traces | 0.071s run time
tests/test_scrubber.py:139: in test_breadcrumb_extra_scrubbing
    assert event["_meta"]["breadcrumbs"] == {
E   AssertionError: assert {'values': {'0': {'data': {'password': {'': {'rem': [['!config', 's']]}}}}}} == {'values': {'': {'len': [1]},\n            '0': {'data': {'password': {'': {'rem': [['!config', 's']]}}}}}}
E     Differing items:
E     {'values': {'0': {'data': {'password': {'': {'rem': [...]}}}}}} != {'values': {'': {'len': [1]}, '0': {'data': {'password': {'': {'rem': [...]}}}}}}
E     Full diff:
E       {
E     -  'values': {'': {'len': [1]},
E     -             '0': {'data': {'password': {'': {'rem': [['!config',
E     ?  ^^^^^^^^^^^
E     +  'values': {'0': {'data': {'password': {'': {'rem': [['!config',
E     ?  ^^^^^^^^^^^
E                                                             's']]}}}}},
E       }

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant