fix: Session storage access throws when disabled

src/session/fetchSession.test.ts

@@ -1,13 +1,19 @@
-import { afterEach, beforeAll, expect, it } from '@jest/globals';
+import { afterEach, beforeAll, expect, it, jest } from '@jest/globals';
 
 import { REPLAY_SESSION_KEY } from './constants';
 import { fetchSession } from './fetchSession';
 
+const oldSessionStorage = window.sessionStorage;
+
 beforeAll(() => {
   window.sessionStorage.clear();
 });
 
 afterEach(() => {
+  Object.defineProperty(window, 'sessionStorage', {
+    writable: true,
+    value: oldSessionStorage,
+  });
   window.sessionStorage.clear();
 });
 
@@ -43,3 +49,16 @@ it('fetches an invalid session', function () {
 
   expect(fetchSession(SAMPLE_RATES)).toBe(null);
 });
+
+it('safely attempts to fetch session when Session Storage is disabled', function () {
+  Object.defineProperty(window, 'sessionStorage', {
+    writable: true,
+    value: {
+      getItem: () => {
+        throw new Error('No Session Storage for you');
+      },
+    },
+  });
+
+  expect(fetchSession(SAMPLE_RATES)).toEqual(null);
+});

src/session/fetchSession.ts

@@ -16,14 +16,15 @@ export function fetchSession({
     return null;
   }
 
-  const sessionStringFromStorage =
-    window.sessionStorage.getItem(REPLAY_SESSION_KEY);
+  try {
+    // This can throw if cookies are disabled
+    const sessionStringFromStorage =
+      window.sessionStorage.getItem(REPLAY_SESSION_KEY);
 
-  if (!sessionStringFromStorage) {
-    return null;
-  }
+    if (!sessionStringFromStorage) {
+      return null;
+    }
 
-  try {
     const sessionObj = JSON.parse(sessionStringFromStorage);
 
     return new Session(

src/session/saveSession.ts

@@ -10,6 +10,6 @@ export function saveSession(session: Session) {
   try {
     window.sessionStorage.setItem(REPLAY_SESSION_KEY, JSON.stringify(session));
   } catch {
-    // this shouldn't happen
+    // Ignore potential SecurityError exceptions
   }
 }