Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues causing the CI to fail:
Fix sentry-rails' test failures caused by Zeitwerk exception
By default, Rails eager loads the app through Zeitwerk and registers
future eager load calls with the
after_class_unload
hook. This hookmakes sure the app would be eagerly reloaded after the app is unloaded.
(code)
Since version 2.6.5, Zeitwerk raises an error when the app is being
eager loaded without a proper setup.
Our test app is not properly setup for being reloaded. So when the app
is unloaded, it's not ready for the next eager load call, which means
it'd trigger the error mentioned in 2.
So this PR simply marks the app as not reloadable, which means it doesn't register the callback mentioned in 1 and avoids the later errors.
Fix sentry-resque's test failure caused by
mono_logger
It's caused by
mono_logger
(a resque dependency)'s conflict with Ruby 3.3'sLogger
. I've opened an issue and worked around it by changing Resque's logger in our tests.Fix sentry-ruby's test failure caused by error message change
#skip-changelog