Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put development/test dependencies into a shared Gemfile #2192

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Dec 6, 2023

With 6 gems under this repo, it's been a headache to update development tooling for them with consistency. I think using a shared Gemfile to host all development (e.g. debug, irb) and test (e.g. rspec) dependencies will make this easier.

It also fixes the master CI as debug now requires Ruby 2.7+.

#skip-changelog

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2192 (0a9ef63) into master (f3e94e0) will increase coverage by 2.62%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
+ Coverage   64.06%   66.68%   +2.62%     
==========================================
  Files          84       98      +14     
  Lines        3339     3659     +320     
==========================================
+ Hits         2139     2440     +301     
- Misses       1200     1219      +19     
Components Coverage Δ
sentry-ruby 55.95% <ø> (ø)
sentry-rails 94.98% <ø> (+0.01%) ⬆️
sentry-sidekiq 94.53% <ø> (∅)
sentry-resque 92.06% <ø> (∅)
sentry-delayed_job 94.44% <ø> (∅)
sentry-opentelemetry 100.00% <ø> (ø)

see 14 files with indirect coverage changes

@st0012 st0012 merged commit 50dc58a into master Dec 6, 2023
98 of 99 checks passed
@st0012 st0012 deleted the unify-development-dependencies branch December 6, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants