Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying on fugit #2519

Merged

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Jan 23, 2025

It is an overkill to have a (implicit) dependency
on fugit, especially that it doesn't even offer
a public interface to do what we need.

It's older version don't support timezones in cron which I believe is the culprit in #2513.

Even if it's not, I still think it's a good change.

@solnic solnic linked an issue Jan 23, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.32%. Comparing base (a4e76ce) to head (33835f3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
- Coverage   69.78%   69.32%   -0.46%     
==========================================
  Files         125      125              
  Lines        4719     4721       +2     
==========================================
- Hits         3293     3273      -20     
- Misses       1426     1448      +22     
Components Coverage Δ
sentry-ruby 60.00% <ø> (-0.60%) ⬇️
sentry-rails 96.76% <ø> (ø)
sentry-sidekiq 97.08% <100.00%> (-0.02%) ⬇️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
...-sidekiq/lib/sentry/sidekiq-scheduler/scheduler.rb 96.77% <100.00%> (-0.11%) ⬇️

... and 4 files with indirect coverage changes

It is an overkill to have a (implicit) dependency
on fugit, especially that it doesn't even offer
a public interface to do what we need.

It's older version don't support timezones in cron
which I believe is the culprit in #2513.

Even if it's not, I still think it's a good change.
@solnic solnic force-pushed the solnic/2513-handle-timezone-when-provided-in-sidekiq_cron branch from fccf7f0 to 33835f3 Compare January 23, 2025 12:19
@solnic solnic requested review from sl0thentr0py and st0012 January 23, 2025 12:23
@solnic solnic merged commit 8f05729 into master Jan 23, 2025
147 of 148 checks passed
@solnic solnic deleted the solnic/2513-handle-timezone-when-provided-in-sidekiq_cron branch January 23, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Timezone when provided in sidekiq_cron
2 participants