Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log warnings about missing deps when profiling is not enabled #2542

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Feb 5, 2025

Quick follow-up after #2537

I really tried to do it without introducing a new method but it was hopeless. I also think we need a robust mechanism for checking if a 3rd party dep is present and this is the first step in that direction.

Refs #2534

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (b5a4948) to head (ffe4f77).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry-ruby.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
- Coverage   69.40%   69.34%   -0.06%     
==========================================
  Files         126      126              
  Lines        4723     4727       +4     
==========================================
  Hits         3278     3278              
- Misses       1445     1449       +4     
Components Coverage Δ
sentry-ruby 60.12% <75.00%> (-0.07%) ⬇️
sentry-rails 97.48% <ø> (ø)
sentry-sidekiq 95.52% <ø> (-0.38%) ⬇️
sentry-resque 92.64% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 85.51% <100.00%> (-0.35%) ⬇️
sentry-ruby/lib/sentry-ruby.rb 67.55% <50.00%> (-0.16%) ⬇️

... and 2 files with indirect coverage changes

@solnic solnic marked this pull request as ready for review February 5, 2025 13:39
@solnic solnic requested review from sl0thentr0py and st0012 February 5, 2025 13:39
@sl0thentr0py sl0thentr0py merged commit 40877c8 into master Feb 5, 2025
137 of 149 checks passed
@sl0thentr0py sl0thentr0py deleted the solnic/2534-avoid-profiler-dep-warnings-part-2 branch February 5, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants