Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Replace chrono usage with time/SystemTime #409

Merged
merged 3 commits into from
Jan 21, 2022
Merged

ref: Replace chrono usage with time/SystemTime #409

merged 3 commits into from
Jan 21, 2022

Conversation

Swatinem
Copy link
Member

The public API only uses SystemTime, internally we use time:0.3 for formatting and parsing.

fixes #375

@Swatinem Swatinem requested a review from a team January 17, 2022 13:15
@Swatinem
Copy link
Member Author

Oh well:

error: failed to parse manifest at `/home/runner/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/time-0.3.5/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature

Guess we gotta bump our MSRV maybe?

time-rs/time@e4d09e2

@Swatinem Swatinem force-pushed the ref/time branch 2 times, most recently from 9fc1278 to 06a5baf Compare January 21, 2022 11:22
@Swatinem Swatinem merged commit ecdb24a into master Jan 21, 2022
@Swatinem Swatinem deleted the ref/time branch January 21, 2022 11:40
MarijnS95 added a commit to MarijnS95/sentry-contrib-rust that referenced this pull request Jan 21, 2022
@MarijnS95
Upgrade to Sentry 0.24 and use public SystemTime
9a4db0b 
Sentry just released 0.24.1, and switched away from `chrono` in [409] to
address `RUSTSEC-2020-0159` and now only uses `std::time::SystemTime` in
its public API.

[409]: getsentry/sentry-rust#409
@MarijnS95 MarijnS95 mentioned this pull request Jan 21, 2022
Merged
3 tasks
Jake-Shadle added a commit to EmbarkStudios/sentry-contrib-rust that referenced this pull request Jan 21, 2022
@MarijnS95 @Jake-Shadle
Upgrade to Sentry 0.24 and use public SystemTime (#10)
1dc6f19 
* Upgrade to Sentry 0.24 and use public `SystemTime`

Sentry just released 0.24.1, and switched away from `chrono` in [409] to
address `RUSTSEC-2020-0159` and now only uses `std::time::SystemTime` in
its public API.

[409]: getsentry/sentry-rust#409

* Fix clippy lints

Co-authored-by: Jake Shadle <[email protected]>
@Swatinem Swatinem mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loewenheim loewenheim loewenheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0159: Potential segfault in localtime_r invocations
2 participants
@Swatinem @loewenheim