add server_name to transaction data #694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently transactions do not include a
server_name
which makes it harder to know where a transaction occurred.According to the transaction docs:
And the events docs include
server_name
so I don't see any reason not to include it.Perhaps in the future it might make more sense to have a common struct between the two that gets flattened (through serde) such that when
Event
gets new fields that may be useful in aTransaction
then it'll already be there (as long as the function to enrich that hypothetical shared struct is used in both places). This, however, is outside of the scope of what I need at this time so I only did the smallest thing I needed.