Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentry-tower: Update axum dependency to v0.8 #718

Merged
merged 1 commit into from
Jan 7, 2025
Merged

sentry-tower: Update axum dependency to v0.8 #718

merged 1 commit into from
Jan 7, 2025

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Jan 2, 2025

@rubdos rubdos mentioned this pull request Jan 2, 2025
Closed
Swatinem
Swatinem approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check why axum 0.7 is still being pulled into the dependencies?

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jan 7, 2025

can you check why axum 0.7 is still being pulled into the dependencies?

tonic is (optionally) used by sentry-tower and that is using axum, but unfortunately they haven't released a version with axum 0.8 support yet. is there a better way to handle this situation?

@Swatinem Swatinem merged commit 5cdf7fc into getsentry:master Jan 7, 2025
14 checks passed
@Swatinem
Copy link
Member

Swatinem commented Jan 7, 2025

Probably not in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @Swatinem