Skip to content

Commit

Permalink
ref(metrics): Remove metrics summaries (#82073)
Browse files Browse the repository at this point in the history
Remove all mentions of metrics summaries from backend code.
  • Loading branch information
jjbayer authored and evanh committed Dec 17, 2024
1 parent affdc73 commit ba5d4bc
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 132 deletions.
5 changes: 0 additions & 5 deletions src/sentry/api/serializers/models/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ class TransactionEventFields(TypedDict, total=False):
endTimestamp: datetime
measurements: Any
breakdowns: Any
_metrics_summary: Any


class EventSerializerResponse(
Expand Down Expand Up @@ -377,10 +376,6 @@ def __serialize_transaction_attrs(self, attrs, obj) -> TransactionEventFields:
"breakdowns": obj.data.get("breakdowns"),
}

# The _ reflects the temporary nature of this field.
if (transaction_metrics_summary := obj.data.get("_metrics_summary")) is not None:
transaction_attrs["_metrics_summary"] = transaction_metrics_summary

return transaction_attrs

def __serialize_error_attrs(self, attrs, obj) -> ErrorEventFields:
Expand Down
5 changes: 0 additions & 5 deletions src/sentry/options/defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -1128,11 +1128,6 @@
# Controls the rollout rate in percent (`0.0` to `1.0`) for metric stats.
register("relay.metric-stats.rollout-rate", default=0.0, flags=FLAG_AUTOMATOR_MODIFIABLE)

# Controls the sample rate of metrics summaries computation in Relay.
register(
"relay.compute-metrics-summaries.sample-rate", default=0.0, flags=FLAG_AUTOMATOR_MODIFIABLE
)

# Controls whether generic inbound filters are sent to Relay.
register("relay.emit-generic-inbound-filters", default=False, flags=FLAG_AUTOMATOR_MODIFIABLE)

Expand Down
1 change: 0 additions & 1 deletion src/sentry/relay/globalconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"relay.metric-bucket-distribution-encodings",
"relay.metric-stats.rollout-rate",
"relay.span-extraction.sample-rate",
"relay.compute-metrics-summaries.sample-rate",
"relay.span-normalization.allowed_hosts",
]

Expand Down
120 changes: 0 additions & 120 deletions src/sentry/search/events/datasets/metrics_summaries.py

This file was deleted.

1 change: 0 additions & 1 deletion tests/sentry/api/endpoints/test_relay_globalconfig_v3.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def inner(version, global_):
"relay.span-usage-metric": True,
"relay.cardinality-limiter.mode": "passive",
"profiling.generic_metrics.functions_ingestion.enabled": True,
"relay.compute-metrics-summaries.sample-rate": 1.0,
"relay.metric-bucket-distribution-encodings": {
"custom": "array",
"metric_stats": "array",
Expand Down

0 comments on commit ba5d4bc

Please sign in to comment.