Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature flag for stacktrace linking #56416

Closed
malwilley opened this issue Sep 18, 2023 · 1 comment · Fixed by #59729
Closed

Remove feature flag for stacktrace linking #56416

malwilley opened this issue Sep 18, 2023 · 1 comment · Fixed by #59729
Assignees
@ceorourke
Labels
Product Area: Issues

Comments

@malwilley
Copy link
Member

The flag organizations:integrations-stacktrace-link has been around for a long time, but is a feature that should be included in all Sentry installations. We should remove it.
@getsantry
Copy link
Contributor

getsantry bot commented Sep 18, 2023

Routing to @getsentry/product-owners-issues for triage ⏲️

@malwilley malwilley mentioned this issue Sep 18, 2023
Closed
@ceorourke ceorourke reopened this Nov 7, 2023
@ceorourke ceorourke self-assigned this Nov 7, 2023
@ceorourke ceorourke mentioned this issue Nov 9, 2023
Merged
ceorourke added a commit that referenced this issue Nov 9, 2023
@ceorourke
chore(stacktrace linking): Remove feature flag (#59729)
31c5e61 
Remove the stacktrace linking feature flag as it's been out for all
plans for a long time now.

Removing getsentry references here:
getsentry/getsentry#12021
Removed front end references here:
#59575

There are still kind of mentions of it for the `IntegrationFeature`
[here](https://github.com/getsentry/sentry/blob/master/src/sentry/models/integrations/integration_feature.py#L41)
but this is used for defining features a sentry app has, like so:
<img width="617" alt="Screenshot 2023-11-09 at 10 38 53 AM"
src="https://github.com/getsentry/sentry/assets/29959063/3b762e86-4407-445e-88ec-cf937ffd66d0">

I checked and there are ones like `integrations-project-management` for
example that are not a feature flag, so it seems okay to remove this.


Closes #56416
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ceorourke ceorourke

Labels
Product Area: Issues
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(stacktrace linking): Remove feature flag getsentry/sentry
2 participants
@malwilley @ceorourke