-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(feat): Support pyenv/Python installation on Big Sur #22257
Conversation
4cbe487
to
9baad70
Compare
I'll try this out tonight. |
Installing Python via pyenv on Big Sur for older Python versions requires: * Setting LDFLAGS for zlib (pyenv/pyenv#1711) * Patching the source code Once a new release of pyenv is released and we use a newer Python 3 version we will not need all these hacks and all Mac versions will be able to use the same code paths. Fixes #22497
9baad70
to
3b26758
Compare
@joshuarli Hi Josh, please let me know if you will be able to give it a try or if I should ask for another person that has Big Sur already installed. Thanks! |
Okay, removing my 3.6.10 and starting out with a slightly outdated pyenv (pyenv@943015ebb2ee2ec3b249e1177d8b8531d0ee3960) on Big Sur. However, it does include the proper zlib ldflags patch.
Tried Edit: never mind, I forgot to checkout the branch, haha. I see python's configure stuff being patched and it works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for taking care of this. You have my blessing.
I expect we can only totally remove all this once Sentry's on 3.8, I have no problems compiling 3.8.6 OOTB.
Thank you Josh for testing this out! |
Installing Python via pyenv on Big Sur for older Python versions requires:
Once a new release of pyenv is released and we use a newer Python 3 version
we will not need all these hacks and all Mac versions will be able to use
the same code paths.
Fixes #22497