SessionNoAuthTokenAuthentication custom authenticator #53850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53850 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 4963 4964 +1
Lines 209669 209733 +64
Branches 35703 35712 +9
=======================================
+ Hits 166737 166799 +62
- Misses 37814 37815 +1
- Partials 5118 5119 +1
|
oioki
changed the title
There was a problem hiding this comment.
This PR is forbidding users from passing in a bearer token to our ApiTokensEndpoint right? The previous SessionAuthentication used would just ignore passed tokens I think (feel free to correct me), so does this mean that we now strictly forbid tokens here, and, if a user has an active session and passes a token, we 403 as well?
EricHasegawa
approved these changes
Jul 31, 2023
mdtro
approved these changes
Jul 31, 2023
dashed
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.