ref(replays): Add replay-video organization denylist handling

[cmanallen]

Relates to: #64379

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.65%. Comparing base (6510315) to head (138af9a).
Report is 1235 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #69324      +/-   ##
==========================================
+ Coverage   78.79%   79.65%   +0.86%     
==========================================
  Files        6438     6440       +2     
  Lines      286107   286346     +239     
  Branches    49306    49351      +45     
==========================================
+ Hits       225433   228098    +2665     
+ Misses      60237    57811    -2426     
  Partials      437      437              

Files	Coverage Δ
src/sentry/conf/server.py	89.18% <ø> (ø)
src/sentry/features/temporary.py	100.00% <ø> (ø)
src/sentry/options/defaults.py	100.00% <ø> (ø)
src/sentry/relay/config/__init__.py	96.06% <ø> (ø)
src/sentry/replays/consumers/recording_buffered.py	98.56% <100.00%> (+35.32%)	⬆️
src/sentry/replays/usecases/ingest/__init__.py	96.36% <100.00%> (+0.10%)	⬆️

... and 226 files with indirect coverage changes

[jjbayer]

getsentry/relay#3439 made it into release 24.4.0, so you might get a problem with customer relays of that version skipping replay videos because the feature flag is now missing.

To be 100% compatible we need to keep the feature flag emitted from sentry as true, and marked as deprecated in Relay (see for example https://github.com/getsentry/relay/blob/03643c31bd113ff1ab52107828abeae75de2b469/relay-dynamic-config/src/feature.rs#L117-L120).

[cmanallen]

What's the recommendation for this PR? What files need to be unchanged and for how long do we need to carry the feature flag?

There's two options:

1. Do nothing and tell users who encounter problems to upgrade their Relay to 24.4.1.
2. Re-introduce the feature flag in Relay as Deprecated (only to forward it to extern Relays), and hard-code it to true on the sentry side. I believe the rule of thumb is to keep it around for ~six months.

I would personally go for option 1 because the current problem only affects 24.4.0 (IIUC), so upgrading to 24.4.1 is a reasonable ask IMO.

[cmanallen]

@bruno-garcia Can you help @aliu3ntry drive this while I'm out.

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀