fix(replay): Remove browser from table if all mobile replays #74796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
approved these changes
Jul 23, 2024
Bundle ReportChanges will decrease total bundle size by 7.25kB ⬇️
|
| @@ -80,7 +88,7 @@ function GroupReplays({group}: Props) { | |||
| isFetching={isFetching} | |||
| replays={[]} | |||
| sort={undefined} | |||
| visibleColumns={VISIBLE_COLUMNS} | |||
| visibleColumns={allMobileProj ? VISIBLE_COLUMNS_MOBILE : VISIBLE_COLUMNS} | |||
There was a problem hiding this comment.
this ternary seems to be used a lot throughout this file, can we make it a constant up top?
| @@ -52,6 +62,7 @@ function GroupReplays({group}: Props) { | |||
| location, | |||
| organization, | |||
| }); | |||
| const {allMobileProj} = useAllMobileProj(); | |||
There was a problem hiding this comment.
oo sorry, i meant, can we move the visibleColumns definition to under here? that way we don't need a function (we don't need to pass in allMobileProj then, can just case directly on allMobileProj)
There was a problem hiding this comment.
actually, what do you think is better🤔 because i see with that method we'd have to define the const twice
There was a problem hiding this comment.
there's three functional components using VISIBLE_COLUMNS in this file so I don't think we can do it better without a function :(
michellewzhang
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74747