Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(metrics): Remove extrapolation code #76780

Merged

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Aug 30, 2024

closes #76782

@priscilawebdev priscilawebdev requested review from a team as code owners August 30, 2024 09:21
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 30, 2024
@shellmayr
Copy link
Member

@priscilawebdev something still seems to be off in the derefed-json openapi test

Copy link
Member

@vgrozdanic vgrozdanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I would just suggest that we wait until Monday before merging and deploying this, since there are (although straightforward) changes to project configs generation, which can break a lot of things

@priscilawebdev
Copy link
Member Author

@vgrozdanic sure I am not merging my PRs today 😄

Copy link
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1470,36 +1470,6 @@
flags=FLAG_AUTOMATOR_MODIFIABLE,
)

# Enables extrapolation on the `transactions` namespace.
register(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either remove these in a separate PR, or ensure that https://github.com/getsentry/sentry-options-automator/pull/2199 is merged and applied before this PR.

@priscilawebdev
Copy link
Member Author

@shellmayr Yes, I noticed that. I tried running the command to update the snapshots, but it appears to be deprecated and didn't work. In any case, the test isn't required

…cila/ref/metrics/remove-extrapolation-backend
Base automatically changed from priscila/ref/metrics/remove-extrapolation-ui to master September 3, 2024 07:33
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #76780      +/-   ##
==========================================
- Coverage   78.20%   78.15%   -0.06%     
==========================================
  Files        6896     6905       +9     
  Lines      306337   306778     +441     
  Branches    50222    50275      +53     
==========================================
+ Hits       239577   239748     +171     
- Misses      60362    60668     +306     
+ Partials     6398     6362      -36     

@priscilawebdev priscilawebdev merged commit b50d95d into master Sep 3, 2024
49 of 50 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/metrics/remove-extrapolation-backend branch September 3, 2024 08:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove backend codebase for metrics extrapolation
4 participants