-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(metrics): Remove extrapolation code #76780
ref(metrics): Remove extrapolation code #76780
Conversation
@priscilawebdev something still seems to be off in the derefed-json openapi test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I would just suggest that we wait until Monday before merging and deploying this, since there are (although straightforward) changes to project configs generation, which can break a lot of things
@vgrozdanic sure I am not merging my PRs today 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1470,36 +1470,6 @@ | |||
flags=FLAG_AUTOMATOR_MODIFIABLE, | |||
) | |||
|
|||
# Enables extrapolation on the `transactions` namespace. | |||
register( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either remove these in a separate PR, or ensure that https://github.com/getsentry/sentry-options-automator/pull/2199 is merged and applied before this PR.
@shellmayr Yes, I noticed that. I tried running the command to update the snapshots, but it appears to be deprecated and didn't work. In any case, the test isn't required |
…cila/ref/metrics/remove-extrapolation-backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #76780 +/- ##
==========================================
- Coverage 78.20% 78.15% -0.06%
==========================================
Files 6896 6905 +9
Lines 306337 306778 +441
Branches 50222 50275 +53
==========================================
+ Hits 239577 239748 +171
- Misses 60362 60668 +306
+ Partials 6398 6362 -36 |
closes #76782