flag(ourlogs): Add product feature flag (frontend/backend) #81930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
k-fish
changed the title
The comment regarding order seems to be false
Dav1dde
approved these changes
Jan 15, 2025
k-fish
added a commit
to getsentry/relay
that referenced
this pull request
Jan 20, 2025
This adds log ingestion (currently only working for the OTel log format) behind a feature flag 'organizations:ourlogs-ingestion'. This PR aims to be the minimum possible to support local and test-org ingestion before we move to dogfooding.  Other notes: - We need to add two `DataCategory`s because we need to track quantity (for current discarded breadcrumb client outcome tracking) and also bytes for total log bytes ingested, which is one of the quota recommendations. - Eventually we will convert Breadcrumbs into logs as well, very similar to span extraction for spans on the event. How exactly that will work is still being discussed with product and sdk folks. - The name `ourlogs` is an internal name to disambiguate between 'our log product' logs (corny, I know) and internally created logs. User facing strings will be set to 'Log' to avoid exposing implementation details. - Depends on getsentry/sentry#81930 for the ingest feature flag.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
The classic start to every project.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classic start to every project.