Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perf): Cleanup dead Web Vitals code #82051

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

0Calories
Copy link
Member

@0Calories 0Calories commented Dec 12, 2024

This PR deletes a lot of old frontend code that is no longer used in the product. Some components that are still being used have been moved from their respective directories within performance to insights/browser/webVitals/components/legacy

Deleted views:

  • vitalDetail view
  • transactionVitals view

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 12, 2024
@0Calories 0Calories marked this pull request as ready for review December 16, 2024 16:07
@0Calories 0Calories requested review from a team as code owners December 16, 2024 16:07
@DominikB2014
Copy link
Contributor

The transaction vitals component is currently used actually, here's an example link https://sentry.sentry.io/performance/summary/vitals/?project=11276&query=&statsPeriod=24h&transaction=%2Finsights%2Fbackend

@0Calories
Copy link
Member Author

@DominikB2014 but how do you navigate to that page? And what advantage does this page even give us over our new web vitals module? In my opinion, it just adds to an already cluttered and confusing experience

@DominikB2014
Copy link
Contributor

@DominikB2014 but how do you navigate to that page?

If you go to the performance section in the sidebar, click on any frontend transaction, you should see the web vitals tab.

And what advantage does this page even give us over our new web vitals module? In my opinion, it just adds to an already cluttered and confusing experience

We original removed the old "transactionVitals" views, but we had several strong complaints that customers liked these old views. So until we have something similar in the new web vitals view, we've decided to keep it for now. There's an issue up for that
#78060

@0Calories
Copy link
Member Author

Ah thanks for the context, Dom

@getsantry
Copy link
Contributor

getsantry bot commented Jan 9, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants