-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(perf): Cleanup dead Web Vitals code #82051
base: master
Are you sure you want to change the base?
Conversation
482b832
to
885bf83
Compare
The transaction vitals component is currently used actually, here's an example link https://sentry.sentry.io/performance/summary/vitals/?project=11276&query=&statsPeriod=24h&transaction=%2Finsights%2Fbackend |
@DominikB2014 but how do you navigate to that page? And what advantage does this page even give us over our new web vitals module? In my opinion, it just adds to an already cluttered and confusing experience |
If you go to the performance section in the sidebar, click on any frontend transaction, you should see the web vitals tab.
We original removed the old "transactionVitals" views, but we had several strong complaints that customers liked these old views. So until we have something similar in the new web vitals view, we've decided to keep it for now. There's an issue up for that |
Ah thanks for the context, Dom |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This PR deletes a lot of old frontend code that is no longer used in the product. Some components that are still being used have been moved from their respective directories within
performance
toinsights/browser/webVitals/components/legacy
Deleted views: