-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issue-details): Make View JSON button more visible #83145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BRING IT BACK. also maybe hide on small screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how dare you
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83145 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 9446 9446
Lines 536656 536656
Branches 21115 21115
=======================================
Hits 470018 470018
Misses 66279 66279
Partials 359 359 |
{ | ||
key: 'view-json', | ||
label: t('View JSON'), | ||
onAction: downloadJson, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill add it back for the small screens where we hide the other button
this pr makes the view JSON button more visible in the streamlined issue details experience, which addresses a common piece of feedback. design follows what we are doing for the "Processing Error" button in the same section of the page <img width="304" alt="Screenshot 2025-01-09 at 11 15 35 AM" src="https://github.com/user-attachments/assets/c4a94475-8c72-4f45-8ce7-4d0776ed243e" />
this pr makes the view JSON button more visible in the streamlined issue details experience, which addresses a common piece of feedback. design follows what we are doing for the "Processing Error" button in the same section of the page