Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-details): Make View JSON button more visible #83145

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

roggenkemper
Copy link
Member

@roggenkemper roggenkemper commented Jan 9, 2025

this pr makes the view JSON button more visible in the streamlined issue details experience, which addresses a common piece of feedback. design follows what we are doing for the "Processing Error" button in the same section of the page

Screenshot 2025-01-09 at 11 15 35 AM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 9, 2025
@roggenkemper roggenkemper marked this pull request as ready for review January 9, 2025 00:22
@roggenkemper roggenkemper requested a review from a team as a code owner January 9, 2025 00:22
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BRING IT BACK. also maybe hide on small screens

Copy link
Member

@MichaelSun48 MichaelSun48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how dare you

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #83145   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files        9446     9446           
  Lines      536656   536656           
  Branches    21115    21115           
=======================================
  Hits       470018   470018           
  Misses      66279    66279           
  Partials      359      359           

Comment on lines 155 to 159
{
key: 'view-json',
label: t('View JSON'),
onAction: downloadJson,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill add it back for the small screens where we hide the other button

@roggenkemper roggenkemper merged commit 07e60c1 into master Jan 9, 2025
40 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/addjsonbutton branch January 9, 2025 19:48
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
this pr makes the view JSON button more visible in the streamlined issue
details experience, which addresses a common piece of feedback. design
follows what we are doing for the "Processing Error" button in the same
section of the page

<img width="304" alt="Screenshot 2025-01-09 at 11 15 35 AM"
src="https://github.com/user-attachments/assets/c4a94475-8c72-4f45-8ce7-4d0776ed243e"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants