Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(profiling): First pass to consolidate profile providers #83274

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zylphrex
Copy link
Member

This makes the 2 profile provider components more similar in preparation to merge them into 1 soon.

This makes the 2 profile provider components more similar in preparation to
merge them into 1 soon.
@Zylphrex Zylphrex requested a review from a team as a code owner January 10, 2025 22:13
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
8503 2 8501 2
View the top 2 failed tests by shortest run time
ContinuousProfileProvider requires start, end and profilerId
Stack Traces | 1.02s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: StringContaining "Failed to fetch continuous profile - invalid query parameters."
Received: "Failed to fetch continuous profile - invalid chunk parameters."

Number of calls: 1

Ignored nodes: comments, script, style
...
    at .../views/profiling/continuousProfileProvider.spec.tsx:79:76
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)
ContinuousProfileProvider fetches chunk
Stack Traces | 1.03s run time
Error: expect(jest.fn()).toHaveBeenCalled()

Expected number of calls: >= 1
Received number of calls:    0

Ignored nodes: comments, script, style
...
    at .../views/profiling/continuousProfileProvider.spec.tsx:50:72
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Jan 10, 2025

Bundle Report

Changes will increase total bundle size by 82.87kB (0.27%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.02MB 82.87kB (0.27%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant