-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect aws_profile from Keygroup Config #1049
Conversation
I can confirm that this patch fixes the bug that prevents sample .sops.yml---
creation_rules:
- key_groups:
- kms:
- arn: arn:aws:kms:eu-west-1......
aws_profile: my-profile With latest
|
Oh this was the issue I had here. Would love to see it merged :) |
Any chance somehow can review/approve ? this would be very useful |
@Kouzukii can you change this to be against |
e1958ce
to
2714ec1
Compare
@ajvb done |
almost there :) can someone review it please ? |
@ajvb : Could you review this PR please ? |
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my comment, it would be great if you could rebase and sign-off your commit as we introduced a DCO.
Signed-off-by: Benjamin Ludewig <[email protected]>
Signed-off-by: Benjamin Ludewig <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed some tiny nits I didn't want you to bother with. Thank you very much @Kouzukii! 🍒
A KMS entry in a creation_rule keygroup supports setting aws_profile, but the value is not passed into the KMS MasterKey.
Fixes: #1093