[updatekeys] Fix input-type cli flag being ignored #1694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Schrader <[email protected]>
kleinschrader
force-pushed
the
fix-input-type-updatekeys
branch
from
4a95c6b to
6e16eeb
Compare
|
Sorry, I see that I didn't reply so far. I think your description makes sense; I didn't have time yet to take a closer look at your implementation and I didn't have time to think about whether this is more a bugfix or more a new feature, but I hope I'll have time soon to do so. |
| @@ -45,12 +46,23 @@ func updateFile(opts Opts) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| store := common.DefaultStoreForPath(sc, opts.InputPath) | |||
There was a problem hiding this comment.
I think this should simply be changed to store := common.DefaultStoreForPathOrFormat(sc, opts.InputPath, opts.InputType). That function takes care of everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At my workplace we use sops, but we use yaml files and end them in
.yaml.encinstead of just.yaml.We recently wanted to add a new key and used
sops updatekeys --input-type=yaml <file>however it would throw json decode errors.I do not know go and have never worked with it so this is the best i could conjure up and i didnt mange to get tests to run so i can only say that --input-type now works with updatekeys.
Any feedback is welcome and i am happy to make changes.