Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert exec command for 3.4.0 release #526

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Revert exec command for 3.4.0 release #526

merged 2 commits into from
Sep 12, 2019

Conversation

ajvb
Copy link
Contributor

@ajvb ajvb commented Sep 12, 2019

Building the exec.go subcommand is failing on the windows build. Backing this out from master so that we can release 3.4.0

$ GOOS=windows CGO_ENABLED=0 GO111MODULE=on go build -mod vendor -o
dist/sops-${TRAVIS_TAG}.exe go.mozilla.org/sops/cmd/sops

# go.mozilla.org/sops/cmd/sops/subcommand/exec
cmd/sops/subcommand/exec/exec.go:41:9: undefined: syscall.Mkfifo
cmd/sops/subcommand/exec/exec.go:65:8: undefined: syscall.Setgid
cmd/sops/subcommand/exec/exec.go:70:8: undefined: syscall.Setuid
cmd/sops/subcommand/exec/exec.go:75:8: undefined: syscall.Setreuid
cmd/sops/subcommand/exec/exec.go:80:8: undefined: syscall.Setregid

The command "GOOS=windows CGO_ENABLED=0 GO111MODULE=on go build -mod vendor -o
dist/sops-${TRAVIS_TAG}.exe go.mozilla.org/sops/cmd/sops" failed and exited
with 2 during .

cc @ancat

@ajvb ajvb requested a review from autrilla September 12, 2019 19:17
@ancat
Copy link
Contributor

ancat commented Sep 12, 2019 via email

@ajvb
Copy link
Contributor Author

ajvb commented Sep 12, 2019

@ancat No worries! We should've caught that in code review. That would be awesome! As well though, imo feel free to just make the command linux and osx exclusive and just provide an "Unsupported on Windows" message for windows.

@ajvb ajvb merged commit 14a22d7 into master Sep 12, 2019
@ajvb ajvb deleted the revert-exec-command branch September 12, 2019 20:52
@ajvb ajvb mentioned this pull request Sep 12, 2019
Closed
@codecov-io
Copy link

codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

13 similar comments
@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   36.46%   36.46%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         1044     1044           
  Misses       1725     1725           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3816...5e02dac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autrilla autrilla autrilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajvb @ancat @codecov-io @autrilla