-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update aws-sdk-go dependency #616
Conversation
Is there any change in particular you care about? |
2149212
to
306410d
Compare
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
=======================================
Coverage 37.11% 37.11%
=======================================
Files 21 21
Lines 2891 2891
=======================================
Hits 1073 1073
Misses 1724 1724
Partials 94 94 Continue to review full report at Codecov.
|
306410d
to
e4660eb
Compare
The real driver here is that the regions supported by the AWS SDK are enumerated in the source code. As a result, to use new ore modified regions you must upgrade the SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM :)
@joshua-rutherford I mistakenly merged this into master, but this PR needs to be made against |
Also, can we have a more descriptive commit message than "f", maybe one that captures some of the context given here? |
There are numerous updates to the aws-sdk-go libraries and this upgrades those dependencies only.