Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aws-sdk-go dependency #616

Merged
merged 1 commit into from
Feb 10, 2020
Merged

update aws-sdk-go dependency #616

merged 1 commit into from
Feb 10, 2020

Conversation

joshua-rutherford
Copy link

There are numerous updates to the aws-sdk-go libraries and this upgrades those dependencies only.

@autrilla
Copy link
Contributor

Is there any change in particular you care about?

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #616 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   37.11%   37.11%           
=======================================
  Files          21       21           
  Lines        2891     2891           
=======================================
  Hits         1073     1073           
  Misses       1724     1724           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a354e...e4660eb. Read the comment docs.

@joshua-rutherford
Copy link
Author

The real driver here is that the regions supported by the AWS SDK are enumerated in the source code. As a result, to use new ore modified regions you must upgrade the SDK.

Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM :)

@autrilla autrilla requested a review from ajvb January 31, 2020 17:30
@ajvb ajvb merged commit 94a04e2 into getsops:master Feb 10, 2020
@ajvb
Copy link
Contributor

ajvb commented Feb 10, 2020

@joshua-rutherford I mistakenly merged this into master, but this PR needs to be made against develop. Would you mind recreating it against the develop branch and I can pull it right in?

@scjudd
Copy link
Contributor

scjudd commented Feb 10, 2020

Also, can we have a more descriptive commit message than "f", maybe one that captures some of the context given here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants