Support --input-type for exec-file

[lbonanomi]

This PR resolves #652, adding support for an --input-type argument that will be honored by sops exec-file.

Until the argument for func outputStore was reversed (to use input-type instead of output-type) sops kept crashing with the message:

Error dumping file: No binary data found in tree

This is certainly a debatable fix, but results were positive.

[codecov-commenter]

Codecov Report

Merging #699 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #699   +/-   ##
========================================
  Coverage    38.26%   38.26%           
========================================
  Files           23       23           
  Lines         3335     3335           
========================================
  Hits          1276     1276           
  Misses        1929     1929           
  Partials       130      130           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9e168...da41786. Read the comment docs.

[autrilla]

No, using output-type is correct. Please revert me, or show why you think I'm wrong :D

[lbonanomi]

@autrilla I freely-admit that I'm probably poking the wrong part of this code. Here was my (simplistic) test.

With the file test containing only: "superSecret: superSecretValue"

and a sops/v3/cmd/sops/main.go containing:

func outputStore(context *cli.Context, path string) common.Store {
        //fmt.Println("Doing the right thing")
        //return common.DefaultStoreForPathOrFormat(path, context.String("output-type"))

        fmt.Println("Doing the wrong thing")
        return common.DefaultStoreForPathOrFormat(path, context.String("input-type"))
}

I get the following results:

# sops exec-file --input-type yaml /tmp/test 'cat {}'
Doing the right thing
Error dumping file: No binary data found in tree

# sops exec-file --input-type yaml /tmp/test 'cat {}'
Doing the wrong thing
superSecret: superSecretValue

Thank you for your time.

[autrilla]

I see! I think the right thing to do here would be adding support for --output-type too. The issue is that SOPS tries to decide on the output store to use based on the file name, and assumes it should be binary (since /tmp/test does not have an extension that indicates a known file type). You'll need to make your calls to sops be of the form sops exec-file --input-type yaml --output-type yaml /tmp/test 'cat {}' afterwards.

[lbonanomi]

I think the right thing to do here would be adding support for --output-type too.

Well that's fair. PR is updated for same.

[autrilla]

LGTM other than the small change to the command line help