Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policies suite of functions examples #87

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Policies suite of functions examples #87

merged 5 commits into from
Feb 7, 2025

Conversation

sckott
Copy link
Member

@sckott sckott commented Feb 2, 2025

#68

Series of PRs for re-working examples.

Policies set of fxns

@sckott sckott added this to the v0.2 milestone Feb 2, 2025
@sckott sckott requested a review from seankross February 2, 2025 05:59
@seankross
Copy link
Collaborator

When I run aws_policy_list_versions() the entire Document column is NA, for example aws_policy_list_versions("AmazonRedshiftFullAccess"). Is that expected?

Copy link
Collaborator

@seankross seankross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so great, just the one comment above.

@sckott
Copy link
Member Author

sckott commented Feb 6, 2025

@seankross I'm not sure, but looks like Document is set to be empty in paws package https://github.com/paws-r/paws/blob/e4998ebf58ab980538a338913382fa076591df08/cran/paws.security.identity/R/iam_interfaces.R#L1158

AWS docs https://docs.aws.amazon.com/IAM/latest/APIReference/API_ListPolicyVersions.html and on the command line using aws cli shows no Document field in the output.

So i think we just drop Document if okay with you

@seankross
Copy link
Collaborator

So i think we just drop Document if okay with you

Sounds good to me, thanks

@sckott sckott requested a review from seankross February 6, 2025 22:55
@sckott
Copy link
Member Author

sckott commented Feb 6, 2025

@seankross okay done

Copy link
Collaborator

@seankross seankross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you

@sckott sckott merged commit 03c8dca into dev Feb 7, 2025
7 checks passed
@sckott sckott deleted the egs-policies branch February 7, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants