Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable definition lists #2718

Open
spectria-limina opened this issue Nov 30, 2024 · 4 comments · Fixed by #2763
Open

Enable definition lists #2718

spectria-limina opened this issue Nov 30, 2024 · 4 comments · Fixed by #2763

Comments

@spectria-limina
Copy link

Pullmark now supports definition lists with the ENABLE_DEFINITION_LIST option. Please enable this for Zola.

@Keats
Copy link
Collaborator

Keats commented Dec 1, 2024

Could be added via a setting in config.toml i think

@matthiasschaub
Copy link

I was just about to ask to enable definition lists as well!
The PR which adds support for definition lists is https://github.com/pulldown-cmark/pulldown-cmark/pull/915/files

I use definition lists extensively, and it would be great if Zola supports it.

By the way, I really love Zola and appreciate the simplicity. Thanks for creating and maintaining Zola!

@matthiasschaub
Copy link

Would a PR be welcomed? I never did development in Rust, but this seems not to be too difficult.

@Keats
Copy link
Collaborator

Keats commented Dec 30, 2024

Sure, this one particular feature should be a few lines of change so that's a good one to start

matthiasschaub added a commit to matthiasschaub/zola that referenced this issue Jan 5, 2025
pulldown-cmark markdown parser added support for definition lists in
https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.12.0

Parsing of definition lists using zola is optional and can be enabled
using configuration variable `definition_list = true` (default is
false).

Closes getzola#2718
matthiasschaub added a commit to matthiasschaub/zola that referenced this issue Jan 5, 2025
pulldown-cmark markdown parser added support for definition lists in
https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.12.0

Parsing of definition lists using zola is optional and can be enabled
using configuration variable `definition_list = true` (default is
false).

Closes getzola#2718
Keats pushed a commit that referenced this issue Jan 6, 2025
* build: update pulldown-cmark to 0.12.2

* feat: enable rendering of definition list

pulldown-cmark markdown parser added support for definition lists in
https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.12.0

Parsing of definition lists using zola is optional and can be enabled
using configuration variable `definition_list = true` (default is
false).

Closes #2718

* chore: update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants